Fix become-precedence bug, dead Tailscale install path, and make meshcore config self-sufficient
- ansible_become: true as a group_vars connection variable silently took
precedence over every task-level `become: false` in this repo, so
every "unprivileged" task (pipx installs, user script deploys,
legacy .env.local writes) was actually running as root the whole
time. Move become to a play-level keyword in site.yml instead, which
correctly loses to a task's own become: false. Also stop relying on
ansible_env.HOME (which reflected root's home once facts were
gathered under the old broken setup) and use /home/{{ remote_user }}
directly, with explicit owner/group so ownership self-heals.
- meshcore_capture: 99-user.toml.j2 now defines every broker
(including letsmesh-us/eu) fully rather than assuming
config.d/10-letsmesh.toml was auto-installed — that preset only gets
created on some install paths (fresh install) and not others
(migrate), so the old partial-override form silently dropped
brokers on migrated nodes.
- base: install libffi-dev/pkg-config on armv6 (Pi Zero W) — cffi has
no prebuilt wheel for that architecture and fails to compile
without the headers.
- dm-ashwell: migrated off the legacy layout to the current
installer's system-service layout; drop its layout override now
that it matches the group default.
- meshcore-capture-update.sh: fix a YAML folded scalar (>-) collapsing
the shebang and command onto one line, corrupting the script.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
This commit is contained in:
@@ -29,7 +29,9 @@
|
||||
- name: Write .env.local config (legacy layout)
|
||||
template:
|
||||
src: env.local.j2
|
||||
dest: "{{ ansible_env.HOME }}/.meshcore-packet-capture/.env.local"
|
||||
dest: "/home/{{ remote_user }}/.meshcore-packet-capture/.env.local"
|
||||
owner: "{{ remote_user }}"
|
||||
group: "{{ remote_user }}"
|
||||
mode: "0640"
|
||||
become: false
|
||||
when: meshcore_capture_layout == 'legacy'
|
||||
@@ -56,11 +58,12 @@
|
||||
|
||||
- name: Deploy meshcore-capture-update script
|
||||
copy:
|
||||
content: >-
|
||||
content: |
|
||||
#!/usr/bin/env bash
|
||||
|
||||
bash <(curl -fsSL https://raw.githubusercontent.com/agessaman/meshcore-packet-capture/main/install.sh){{ ' --update' if meshcore_capture_layout != 'legacy' else '' }}
|
||||
dest: "{{ ansible_env.HOME }}/meshcore-capture-update.sh"
|
||||
dest: "/home/{{ remote_user }}/meshcore-capture-update.sh"
|
||||
owner: "{{ remote_user }}"
|
||||
group: "{{ remote_user }}"
|
||||
mode: "0755"
|
||||
become: false
|
||||
|
||||
@@ -69,6 +72,8 @@
|
||||
content: |
|
||||
#!/usr/bin/env bash
|
||||
sudo journalctl -u {{ 'meshcore-capture' if meshcore_capture_layout == 'legacy' else 'meshcore-packet-capture' }} -f
|
||||
dest: "{{ ansible_env.HOME }}/meshcore-capture-logs.sh"
|
||||
dest: "/home/{{ remote_user }}/meshcore-capture-logs.sh"
|
||||
owner: "{{ remote_user }}"
|
||||
group: "{{ remote_user }}"
|
||||
mode: "0755"
|
||||
become: false
|
||||
|
||||
Reference in New Issue
Block a user